refactor: route auth/room/shared logging through soliplex_logging#376
Merged
Conversation
Replace debugPrint in auth, room, and shared modules with structured soliplex_logging Loggers (.warning/.error with error and stackTrace). Add installLogSinks, which registers a ConsoleSink and a StdoutSink and sets the level floor (warning in release, info otherwise), wired in from main. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the migration off
debugPrintand onto structuredsoliplex_logging(following #370's lobby_state/room_screen work) for the auth, room, and shared modules.debugPrintin catch sites across auth (connect_flow,secure_server_storage,server_manager), room (async_action_dialog,features_card), and shared (copy_button) withLogger.warning/Logger.errorcalls that carryerrorandstackTrace.lib/src/core/log_sinks.dartwithinstallLogSinks, which registers aConsoleSink(DevTools/IDE viadart:developer; browser console on web) and aStdoutSink, and sets the level floor —warningin release,infootherwise. Wired in frommain..error; recoverable/per-item failures (restore, clear, clipboard copy, dialog action) at.warning. Both survive the release floor.on PlatformException+on Exceptioncatch pair infeatures_cardandcopy_buttoninto oneon Exceptionbranch — behavior-preserving, sincePlatformExceptionis anExceptionand both branches did identical work.Test
test/core/log_sinks_test.dartverifiesinstallLogSinksregisters both sink transports.flutter analyze: zero issues. Existing widget tests cover the clipboard-failure feedback path.🤖 Generated with Claude Code